linux-kernel - Re: [PATCH 2/3] net: dsa: lantiq_gswip: fix OF child-node lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97b4da00-2aef-fbb1-2336-15a9399aff7b@hauke-m.de>
Date:   Wed, 16 Jan 2019 22:46:35 +0100
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Johan Hovold <johan@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH 2/3] net: dsa: lantiq_gswip: fix OF child-node lookups

On 1/16/19 11:23 AM, Johan Hovold wrote:
> Use the new of_get_compatible_child() helper to look up child nodes to
> avoid ever matching non-child nodes elsewhere in the tree.
> 
> Also fix up the related struct device_node leaks.
> 
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Cc: stable <stable@...r.kernel.org>	# 4.20
> Cc: Hauke Mehrtens <hauke@...ke-m.de>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Acked-by: Hauke Mehrtens <hauke@...ke-m.de>

> ---
>  drivers/net/dsa/lantiq_gswip.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>