linux-kernel - Re: ufshcd_queuecommand() triggering after ufshcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLXhR2Fny4L4wqEHnZ+w0ktTp=ntvxuPU8h-vLwZW51k0Q@mail.gmail.com>
Date:   Wed, 16 Jan 2019 14:14:09 -0800
From:   John Stultz <john.stultz@...aro.org>
To:     Zang Leigang <zangleigang@...ilicon.com>
Cc:     Avri Altman <Avri.Altman@....com>,
        Sahitya Tummala <stummala@...eaurora.org>,
        Christoph Hellwig <hch@....de>, Wei Li <liwei213@...wei.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Evan Green <evgreen@...omium.org>,
        Vijay Viswanath <vviswana@...eaurora.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: ufshcd_queuecommand() triggering after ufshcd_suspend()?

On Sun, Jan 13, 2019 at 7:25 PM Zang Leigang <zangleigang@...ilicon.com> wrote:
>   I think there are two different issues:
>
>   1. clk_gating's state(including state's trace event) and is_suspended is not
>      wrapped by ufshcd_is_clkgating_allowed which Hisilicon's kirin platoform
>      soc does not need but is set and checked in a regular path.
>   2. I think SCSI is necessary to block queue to stop sending to ufs after
>      system suspend or, add a new state for ufs like UFSHCD_STATE_SUSPENDING
>      or what else. hba->is_sys_suspended is too late to stop ufshcd_queuecommand
>

Hey Zang,
  Thanks for the suggestions. I'm not sure I have enough context to
try to come up with a patch. I'll try to take a stab at it, but I'd
appreciate it if  you have any more specific suggestions or patches
for me to try. :)

thanks
-john