linux-kernel - Re: [PATCH] security/apparmor/domain: use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82ead100-3f36-5928-703d-28281c6b5353@canonical.com>
Date:   Wed, 16 Jan 2019 14:31:26 -0800
From:   John Johansen <john.johansen@...onical.com>
To:     Peng Hao <peng.hao2@....com.cn>, jmorris@...ei.org,
        serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security/apparmor/domain: use PTR_ERR_OR_ZERO

On 1/4/19 1:17 AM, Peng Hao wrote:
> The variable 'new' may be NULL, so use PTR_ERR_OR_ZERO instead
> of PTR_ERR.
> 
> Signed-off-by: Peng Hao <peng.hao2@....com.cn>

yep that is a problem unfortunately the fix isn't quite right
we don't want to return 0 for an error here. Instead we can
do

diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
index 08c88de0ffda..11975ec8d566 100644
--- a/security/apparmor/domain.c
+++ b/security/apparmor/domain.c
@@ -1444,7 +1444,10 @@ int aa_change_profile(const char *fqname, int flags)
 			new = aa_label_merge(label, target, GFP_KERNEL);
 		if (IS_ERR_OR_NULL(new)) {
 			info = "failed to build target label";
-			error = PTR_ERR(new);
+			if (!new)
+				error = -ENOMEM;
+			else
+				error = PTR_ERR(new);
 			new = NULL;
 			perms.allow = 0;
 			goto audit;


I have pulled your patch into my apparmor tree with the above revision


> ---
>  security/apparmor/domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
> index 08c88de..7663589 100644
> --- a/security/apparmor/domain.c
> +++ b/security/apparmor/domain.c
> @@ -1444,7 +1444,7 @@ int aa_change_profile(const char *fqname, int flags)
>  			new = aa_label_merge(label, target, GFP_KERNEL);
>  		if (IS_ERR_OR_NULL(new)) {
>  			info = "failed to build target label";
> -			error = PTR_ERR(new);
> +			error = PTR_ERR_OR_ZERO(new);
>  			new = NULL;
>  			perms.allow = 0;
>  			goto audit;
>