linux-kernel - Re: [PATCH v1 01/10] cpufreq: Add thermal_cooling_device pointer to struct cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1718046.8NPD0iV1Wv@aspire.rjw.lan>
Date:   Wed, 16 Jan 2019 23:56:05 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        viresh.kumar@...aro.org, edubezval@...il.com, swboyd@...omium.org,
        dianders@...omium.org, mka@...omium.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 01/10] cpufreq: Add thermal_cooling_device pointer to struct cpufreq_policy

On Monday, January 14, 2019 5:34:53 PM CET Amit Kucheria wrote:
> Several cpufreq drivers register themselves as thermal cooling devices.
> Adding a pointer to struct cpufreq_policy removes the need for them to
> store this pointer in a private data structure.
> 
> We can then auto-register the cpufreq driver as a thermal cooling device
> from cpufreq core code.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> ---
>  include/linux/cpufreq.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index c86d6d8bdfed..7d0cf54125fa 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -95,6 +95,11 @@ struct cpufreq_policy {
>  	struct cpufreq_frequency_table	*freq_table;
>  	enum cpufreq_table_sorting freq_table_sorted;
>  
> +#ifdef CONFIG_CPU_THERMAL
> +	/* Pointer to the cooling device if used for thermal mitigation */
> +	struct thermal_cooling_device *cooldev;
> +#endif
> +

Why here and not at the end of the struct?

>  	struct list_head        policy_list;
>  	struct kobject		kobj;
>  	struct completion	kobj_unregister;
> 

Also, I would suggest combining this one with patch [02/10].