linux-kernel - Re: [PATCH -next] LSM: Make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Jan 2019 13:45:36 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <jmorris@...ei.org>, <serge@...lyn.com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH -next] LSM: Make some functions static

Pls ignore this duplicated patch.

On 2019/1/16 13:33, YueHaibing wrote:
> Fix the follow sparse warning:
> 
> security/security.c:533:5: warning: symbol 'lsm_task_alloc' was not declared. Should it be static?
> security/security.c:554:5: warning: symbol 'lsm_ipc_alloc' was not declared. Should it be static?
> security/security.c:575:5: warning: symbol 'lsm_msg_msg_alloc' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  security/security.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/security/security.c b/security/security.c
> index 9a98c52..750d3f3 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -530,7 +530,7 @@ int lsm_inode_alloc(struct inode *inode)
>   *
>   * Returns 0, or -ENOMEM if memory can't be allocated.
>   */
> -int lsm_task_alloc(struct task_struct *task)
> +static int lsm_task_alloc(struct task_struct *task)
>  {
>  	if (blob_sizes.lbs_task == 0) {
>  		task->security = NULL;
> @@ -551,7 +551,7 @@ int lsm_task_alloc(struct task_struct *task)
>   *
>   * Returns 0, or -ENOMEM if memory can't be allocated.
>   */
> -int lsm_ipc_alloc(struct kern_ipc_perm *kip)
> +static int lsm_ipc_alloc(struct kern_ipc_perm *kip)
>  {
>  	if (blob_sizes.lbs_ipc == 0) {
>  		kip->security = NULL;
> @@ -572,7 +572,7 @@ int lsm_ipc_alloc(struct kern_ipc_perm *kip)
>   *
>   * Returns 0, or -ENOMEM if memory can't be allocated.
>   */
> -int lsm_msg_msg_alloc(struct msg_msg *mp)
> +static int lsm_msg_msg_alloc(struct msg_msg *mp)
>  {
>  	if (blob_sizes.lbs_msg_msg == 0) {
>  		mp->security = NULL;
>