linux-kernel - Re: [PATCH v2 2/3] mtd: spi-nor: mtk-quadspi: add SNOR_HWCAPS_READ to spi_nor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9788fb78-7289-1c5d-51db-75aff997b5e0@microchip.com>
Date:   Wed, 16 Jan 2019 06:05:10 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <ryder.lee@...iatek.com>, <marek.vasut@...il.com>,
        <computersforpeace@...il.com>, <boris.brezillon@...tlin.com>
CC:     <devicetree@...r.kernel.org>, <guochun.mao@...iatek.com>,
        <weijie.gao@...iatek.com>, <linux-kernel@...r.kernel.org>,
        <robh+dt@...nel.org>, <linux-mtd@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/3] mtd: spi-nor: mtk-quadspi: add SNOR_HWCAPS_READ to
 spi_nor_hwcaps mask



On 01/16/2019 04:12 AM, Ryder Lee wrote:
> From: Guochun Mao <guochun.mao@...iatek.com>
> 
> SNOR_HWCAPS_READ should be supported by this controller, so add this
> flag to spi_nor_hwcaps mask.
> 
> Signed-off-by: Guochun Mao <guochun.mao@...iatek.com>
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

> ---
> Changes since v2: Revise commit msg. 
> Changes since v1: none. 
> ---
>  drivers/mtd/spi-nor/mtk-quadspi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c b/drivers/mtd/spi-nor/mtk-quadspi.c
> index 5442993..d9eed68 100644
> --- a/drivers/mtd/spi-nor/mtk-quadspi.c
> +++ b/drivers/mtd/spi-nor/mtk-quadspi.c
> @@ -431,7 +431,8 @@ static int mtk_nor_init(struct mtk_nor *mtk_nor,
>  			struct device_node *flash_node)
>  {
>  	const struct spi_nor_hwcaps hwcaps = {
> -		.mask = SNOR_HWCAPS_READ_FAST |
> +		.mask = SNOR_HWCAPS_READ |
> +			SNOR_HWCAPS_READ_FAST |
>  			SNOR_HWCAPS_READ_1_1_2 |
>  			SNOR_HWCAPS_PP,
>  	};
>