linux-kernel - Re: [RFC v2 6/6] cros_ec: differentiate SCP from EC by feature bit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190116082758.GB23399@dell>
Date:   Wed, 16 Jan 2019 08:27:58 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Pi-Hsun Shih <pihsun@...omium.org>
Cc:     Nicolas Boichat <drinkcat@...omium.org>,
        Enric Balletbo Serra <eballetbo@...il.com>,
        Guenter Roeck <groeck@...omium.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v2 6/6] cros_ec: differentiate SCP from EC by feature bit.

On Tue, 08 Jan 2019, Pi-Hsun Shih wrote:

> Since a SCP and EC would both exist on a system, and use the cros_ec_dev
> driver, we need to differentiate between them for the userspace, or they
> would both be registered at /dev/cros_ec, causing a conflict.
> 
> Cc: Enric Balletbo Serra <eballetbo@...il.com>
> Cc: Guenter Roeck <groeck@...omium.org>
> Signed-off-by: Pi-Hsun Shih <pihsun@...omium.org>
> ---
> Changes from v1:
>  - New patch extracted from Patch 5.
> ---
>  drivers/mfd/cros_ec_dev.c            | 9 +++++++++
>  include/linux/mfd/cros_ec.h          | 1 +
>  include/linux/mfd/cros_ec_commands.h | 2 ++
>  3 files changed, 12 insertions(+)

The (other) Chromium guys are usually pretty active and are more
familiar with this hardware and group of (MFD/Platform) drivers than I
am.  Thus I'm waiting for one of them to provide their thoughts before
applying this.

Just make sure you Cc:ed enough of them!

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog