linux-kernel - Re: [PATCH v2 1/6] dt-bindings: phy-qcom: Add support for msm8998 usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Jan 2019 14:27:43 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <andy.gross@...aro.org>, <david.brown@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <gregkh@...uxfoundation.org>, <balbi@...nel.org>,
        <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2 1/6] dt-bindings: phy-qcom: Add support for msm8998 usb



On 15/01/19 11:38 PM, Bjorn Andersson wrote:
> On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote:
> 
>> USB on msm8998 utilizes the QUSB2 and QMP phys, similar to sdm845.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
>> ---
>>  Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt   | 5 +++++
>>  Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 1 +
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> index 41a1074..6061b6f 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> @@ -9,6 +9,7 @@ Required properties:
>>  	       "qcom,ipq8074-qmp-pcie-phy" for PCIe phy on IPQ8074
>>  	       "qcom,msm8996-qmp-pcie-phy" for 14nm PCIe phy on msm8996,
>>  	       "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
>> +	       "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998,
>>  	       "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
>>  	       "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
>>  	       "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845.
>> @@ -42,6 +43,8 @@ Required properties:
>>  			"aux", "cfg_ahb", "ref".
>>  		For "qcom,msm8996-qmp-usb3-phy" must contain:
>>  			"aux", "cfg_ahb", "ref".
>> +		For "qcom,msm8998-qmp-usb3-phy" must contain:
>> +			"aux", "cfg_ahb", "ref".
>>  		For "qcom,sdm845-qmp-usb3-phy" must contain:
>>  			"aux", "cfg_ahb", "ref", "com_aux".
>>  		For "qcom,sdm845-qmp-usb3-uni-phy" must contain:
>> @@ -60,6 +63,8 @@ Required properties:
>>  		For "qcom,msm8996-qmp-pcie-phy" must contain:
>>  			"phy", "common", "cfg".
>>  		For "qcom,msm8996-qmp-usb3-phy" must contain
>> +		 "phy", "common".
> 
> Odd indentation.
> 
> 
> Apart from this, you have my
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Fixed the indentation and merged it.

Thanks
Kishon