linux-kernel - Re: [PATCH] staging: comedi: Removed not necessary braces for single block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c44b247-e44d-aaff-e0af-544b2c4eb4c0@mev.co.uk>
Date:   Wed, 16 Jan 2019 10:44:11 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Jitendra Khasdev <jkhasdev@...il.com>,
        hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: Removed not necessary braces for single
 block

On 15/01/2019 15:36, Jitendra Khasdev wrote:
> This patch is used to remove not necessary braces for single if block.
> 
> Signed-off-by: Jitendra Khasdev <jkhasdev@...il.com>
> ---
>   drivers/staging/comedi/comedi_fops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 5d2fcbfe02af..38980fad8be4 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
>   	unsigned int n_data = MIN_SAMPLES;
>   	int ret = 0;
>   
> -	if (copy_from_user(&insn, arg, sizeof(insn))) {
> +	if (copy_from_user(&insn, arg, sizeof(insn)))
>   		return -EFAULT;
> -	}
> +
>   
>   	n_data = max(n_data, insn.n);
>   
> 

The patch looks fine. Thanks for the fix!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-