linux-kernel - Re: [PATCH] cpufreq: Don't update new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3588039.3NVSA610fZ@aspire.rjw.lan>
Date:   Wed, 16 Jan 2019 12:57:36 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-pm@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Don't update new_policy on failures

On Monday, January 7, 2019 7:58:54 AM CET Viresh Kumar wrote:
> The local variable "new_policy" isn't getting used in the error path
> since the commit f9f41e3ef99a ("cpufreq: Remove policy create/remove
> notifiers"). Don't update it in error path.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/cpufreq.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 7aa3dcad2175..9a5f82ef40e8 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1305,8 +1305,6 @@ static int cpufreq_online(unsigned int cpu)
>  	if (ret) {
>  		pr_err("%s: Failed to initialize policy for cpu: %d (%d)\n",
>  		       __func__, cpu, ret);
> -		/* cpufreq_policy_free() will notify based on this */
> -		new_policy = false;
>  		goto out_destroy_policy;
>  	}
>  
> 

Applied, thanks!