linux-kernel - Re: [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator support

Open Source and information security mailing list archives

Message-ID: <5C3F3BDF.6070409@hisilicon.com>
Date:   Wed, 16 Jan 2019 22:12:47 +0800
From:   Zhou Wang <wangzhou1@...ilicon.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <linux-crypto@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator
 support

On 2019/1/11 14:34, Zhou Wang wrote:
> On 2019/1/11 14:08, Herbert Xu wrote:
>> On Sat, Dec 22, 2018 at 03:51:44PM +0800, Zhou Wang wrote:
>>>
>>> +static struct crypto_alg hisi_zip_zlib = {
>>> +	.cra_name		= "zlib-deflate",
>>> +	.cra_flags		= CRYPTO_ALG_TYPE_COMPRESS,
>>> +	.cra_ctxsize		= sizeof(struct hisi_zip_ctx),
>>> +	.cra_priority           = 300,
>>> +	.cra_module		= THIS_MODULE,
>>> +	.cra_init		= hisi_zip_alloc_comp_ctx,
>>> +	.cra_exit		= hisi_zip_free_comp_ctx,
>>> +	.cra_u			= {
>>> +		.compress = {
>>> +			.coa_compress	= hisi_zip_compress,
>>> +			.coa_decompress	= hisi_zip_decompress
>>> +		}
>>> +	}
>>> +};
>>
>> Please do not add any new implementations using the compress
>> interface.  You should either use scomp or acomp depending on
>> whether your driver is synchronous or async.

Hi Herbert,

A stupid question: how do we test scomp alg?

It seems we can not use general comp API, e.g. crypto_alloc_comp
to do this.

Could you give me any clue about this?

Best,
Zhou

> 
> OK, current this driver only supports synchronous interface.
> Will fix it in v2.
> 
> Thanks,
> Zhou
> 
>>
>> Thanks,
>>
> 
> _______________________________________________
> Linuxarm mailing list
> Linuxarm@...wei.com
> http://hulk.huawei.com/mailman/listinfo/linuxarm
> 
> .
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives