linux-kernel - Re: [Xen-devel] [PATCH 19/21] treewide: add checks for the return value of memblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Jan 2019 15:32:03 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Mike Rapoport <rppt@...ux.ibm.com>, linux-mm@...ck.org
Cc:     Rich Felker <dalias@...c.org>, linux-ia64@...r.kernel.org,
        devicetree@...r.kernel.org,
        Catalin Marinas <catalin.marinas@....com>,
        Heiko Carstens <heiko.carstens@...ibm.com>, x86@...nel.org,
        linux-mips@...r.kernel.org, Max Filippov <jcmvbkbc@...il.com>,
        Guo Ren <guoren@...nel.org>, sparclinux@...r.kernel.org,
        Christoph Hellwig <hch@....de>, linux-s390@...r.kernel.org,
        linux-c6x-dev@...ux-c6x.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Richard Weinberger <richard@....at>, linux-sh@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        kasan-dev@...glegroups.com,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Mark Salter <msalter@...hat.com>,
        Dennis Zhou <dennis@...nel.org>,
        Matt Turner <mattst88@...il.com>,
        linux-snps-arc@...ts.infradead.org,
        uclinux-h8-devel@...ts.sourceforge.jp,
        Petr Mladek <pmladek@...e.com>, linux-xtensa@...ux-xtensa.org,
        linux-alpha@...r.kernel.org, linux-um@...ts.infradead.org,
        linux-m68k@...ts.linux-m68k.org, Rob Herring <robh+dt@...nel.org>,
        Greentime Hu <green.hu@...il.com>,
        xen-devel@...ts.xenproject.org, Stafford Horne <shorne@...il.com>,
        Guan Xuetao <gxt@....edu.cn>,
        linux-arm-kernel@...ts.infradead.org,
        Michal Simek <monstr@...str.eu>,
        Tony Luck <tony.luck@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paul Burton <paul.burton@...s.com>,
        Vineet Gupta <vgupta@...opsys.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linuxppc-dev@...ts.ozlabs.org,
        "David S. Miller" <davem@...emloft.net>,
        openrisc@...ts.librecores.org
Subject: Re: [Xen-devel] [PATCH 19/21] treewide: add checks for the return
 value of memblock_alloc*()

On 16/01/2019 14:44, Mike Rapoport wrote:
> Add check for the return value of memblock_alloc*() functions and call
> panic() in case of error.
> The panic message repeats the one used by panicing memblock allocators with
> adjustment of parameters to include only relevant ones.
> 
> The replacement was mostly automated with semantic patches like the one
> below with manual massaging of format strings.
> 
> @@
> expression ptr, size, align;
> @@
> ptr = memblock_alloc(size, align);
> + if (!ptr)
> + 	panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__,
> size, align);
> 
> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>

For the Xen part:

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen