linux-kernel - Re: [PATCH] net: dsa: realtek-smi: fix OF child-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190116150502.GH25731@lunn.ch>
Date:   Wed, 16 Jan 2019 16:05:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Johan Hovold <johan@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: realtek-smi: fix OF child-node lookup

On Wed, Jan 16, 2019 at 11:27:08AM +0100, Johan Hovold wrote:
> Use the new of_get_compatible_child() helper to look up child nodes to
> avoid ever matching non-child nodes elsewhere in the tree.
> 
> Also fix up the related struct device_node leaks.
> 
> Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Cc: stable <stable@...r.kernel.org>     # 4.19: 36156f9241cb0
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew