linux-kernel - Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b11ea71-ab65-11b3-2ee1-46f9a9fa145d@suse.de>
Date:   Wed, 16 Jan 2019 16:07:31 +0100
From:   Andreas Färber <afaerber@...e.de>
To:     Jiri Pirko <jiri@...nulli.us>,
        Jian-Hong Pan <starnight@...cu.edu.tw>
Cc:     netdev@...r.kernel.org, linux-lpwan@...ts.infradead.org,
        Ben Whitten <ben.whitten@...rdtech.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

Am 16.01.19 um 15:33 schrieb Jiri Pirko:
> Wed, Jan 16, 2019 at 03:24:54PM CET, starnight@...cu.edu.tw wrote:
>> Signed-off-by: Jian-Hong Pan <starnight@...cu.edu.tw>
>> ---
> 
> Patches like this are in general frowned upon. Do one change in one
> patch. Put some patch description.

This patch simply shouldn't have gone to netdev and LKML, as it is a
fixup against a non-stable tree (missing "lora-next"). Once squashed, it
doesn't matter whether it once had a verbose explanation or not. And I
prefer to not mix style and functional changes.

I simply was too impatient to wait for more respins before being able to
base work on it. ;)

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)