linux-kernel - Re: [PATCH v2,2/2] usb: chipidea: imx: set power polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22968f8c-0a62-7046-c46f-ce7dc8981499@cogentembedded.com>
Date:   Wed, 16 Jan 2019 19:32:08 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Philipp Puschmann <philipp.puschmann@...ix.com>,
        gregkh@...uxfoundation.org
Cc:     robh+dt@...nel.org, mark.rutland@....com, Peter.Chen@....com,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2,2/2] usb: chipidea: imx: set power polarity

Hello!

On 01/16/2019 01:51 PM, Philipp Puschmann wrote:

> This patch adds support to set the power line polarity for i.MX6q/dl.
> 
> To let the USB controller control the power it may be necessary to configure
> the polarity of the power line. So far the polarity was configured
> by Bootloader or alternatively the power line was muxed as gpio and
> driven by a regulator.
> 
> Signed-off-by: Philipp Puschmann <philipp.puschmann@...ix.com>
> ---
> 
> V2: fixed wrong variable name ...
> 
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++
>  drivers/usb/chipidea/ci_hdrc_imx.h | 1 +
>  drivers/usb/chipidea/usbmisc_imx.c | 4 ++++
>  3 files changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index e81de9ca8729..32dc120680fa 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -152,6 +152,9 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)
>  		dev_warn(dev, "No over current polarity defined\n");
>  	}
>  
> +	if (of_find_property(np, "power-active-high", NULL))

   How about of_property_read_bool()?

> +		data->pwr_pol = 1;
> +
>  	if (of_find_property(np, "external-vbus-divider", NULL))
>  		data->evdo = 1;
>  
[...]

MBR, Sergei