linux-kernel - Re: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Jan 2019 22:44:50 +0530
From:   Nishad Kamdar <nishadkamdar@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org,
        Leonardo Brás <leobras.c@...il.com>,
        linux-fbdev@...r.kernel.org, YueHaibing <yuehaibing@...wei.com>,
        Jani Nikula <jani.nikula@...el.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Felix Siegel <felix.siegel@...d.uni-hannover.de>,
        Matthias Wolf <der_wolf_@....de>, linux-kernel@...r.kernel.org,
        Mamta Shukla <mamtashukla555@...il.com>,
        Radek Dostál <radek.dostal@...eamunlimited.com>,
        Renato Soma <renatoys08@...il.com>,
        dri-devel@...ts.freedesktop.org,
        Tim Cofala <cofala@...d.uni-hannover.de>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor
 interface

On Tue, Jan 15, 2019 at 04:02:31PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 15, 2019 at 10:17:09AM +0530, Nishad Kamdar wrote:
> > This switches the fbtft driver to use GPIO descriptors
> > rather than numerical gpios:
> > 
> > Utilize the GPIO library's intrinsic handling of OF GPIOs
> > and polarity. If the line is flagged active low, gpiolib
> > will deal with this.
> > 
> > Remove gpios from platform device structure. Neither assign
> > statically numbers to gpios in platform device nor allow
> > gpios to be parsed as module parameters.
> > 
> > Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> > Changes in v2:
> >  - Merge all patches in a single patch. This is because the
> >    first patch changes par->gpio from an int to a pointer
> >    so all the checks have to be updated in the same patch.
> >    Otherwie it breaks 'git bisect'.
> 
> The "v2" information goes below the --- line please.
> 
> Also, I got 2 copies of this, both different, so I have no idea which to
> apply.  Please fix up and resend a v3.
> 
Sorry for the confusion. I'll fix and resend.

> thanks,
> 
> greg k-h

Thanks for the review.

Regards,
Nishad