linux-kernel - Re: [PATCH 2/8] vop: Cast pointers to uintptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b1f7aac7a3b5261f42979f6ed53713264557bf4.camel@perches.com>
Date:   Wed, 16 Jan 2019 09:39:37 -0800
From:   Joe Perches <joe@...ches.com>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>,
        sudeep.dutt@...el.com, ashutosh.dixit@...el.com,
        gregkh@...uxfoundation.org, arnd@...db.de
Cc:     linux-kernel@...r.kernel.org, Vincent Whitchurch <rabinv@...s.com>
Subject: Re: [PATCH 2/8] vop: Cast pointers to uintptr_t

On Wed, 2019-01-16 at 17:32 +0100, Vincent Whitchurch wrote:
> Fix these on 32-bit:
> 
>  vop_vringh.c:711:13: error: cast from pointer to integer of different
>  size [-Werror=pointer-to-int-cast]
[]
> diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
[]
> @@ -497,7 +497,7 @@ static int _vop_add_device(struct mic_device_desc __iomem *d,
>  	vdev->desc = d;
>  	vdev->dc = (void __iomem *)d + _vop_aligned_desc_size(d);
>  	vdev->dnode = dnode;
> -	vdev->vdev.priv = (void *)(u64)dnode;
> +	vdev->vdev.priv = (void *)(uintptr_t)dnode;

trivia:

unsigned long is more commonly used in the kernel for
these casts.