linux-kernel - Re: [PATCH v8] arm64: dts: sdm845: Add gpu and gmu device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WuVOWYLbNKy=t1+X4a7cjegU+AUyFJmYNHkjYnRzLQBA@mail.gmail.com>
Date:   Wed, 16 Jan 2019 11:13:09 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Jordan Crouse <jcrouse@...eaurora.org>
Cc:     freedreno <freedreno@...ts.freedesktop.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Andy Gross <andy.gross@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        David Brown <david.brown@...aro.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v8] arm64: dts: sdm845: Add gpu and gmu device nodes

Hi,

On Wed, Jan 16, 2019 at 10:03 AM Jordan Crouse <jcrouse@...eaurora.org> wrote:
>
> Add the nodes to describe the Adreno GPU and GMU devices for sdm845.
>
> Signed-off-by: Jordan Crouse <jcrouse@...eaurora.org>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Tested-by: Douglas Anderson <dianders@...omium.org>
> ---
> This has the following dependencies:
>
> [v11,1/9] dt-bindings: opp: Introduce opp-level bindings
> https://patchwork.kernel.org/patch/10755199/
>
> And the following patches already in Rob's msm-next:
> msm-next:d1c9cadea6f7 ("drm/msm/gpu: Remove hardcoded interrupt name")
> msm-next:b08b92546807 ("drm/msm: drop interrupt-names")
> msm-next:24937c540917 ("dt-bindings: drm/msm/a6xx: Document GMU and update GPU bindings")
>
> And finally drm/msm: Fix A6XX support for opp-level
> https://patchwork.freedesktop.org/patch/276756/
>
> Which is not merged because it too depends on Rajendra's stack.

Newer version:

https://lore.kernel.org/patchwork/patch/1032724/

...that one should be able to land earlier since it's simpler.

---

Don't forget that your patch also depends on:

https://lkml.kernel.org/r/20181128185743.75328-2-dianders@chromium.org

...because you won't compile unless gpucc is there.


>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 121 +++++++++++++++++++++++++++++++++++
>  1 file changed, 121 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index f07c4ca..90766fc 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1618,6 +1618,127 @@
>                         };
>                 };
>
> +
> +               gpu@...0000 {

Heads up to Andy that when this lands it should be re-sorted to be
right before gpucc so that the unit addresses are sorted.  :-)  ...and
while doing that we can make sure there's not an extra blank line.


-Doug