linux-kernel - RE: [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB5327656AD22454B054CE0AD08B830@VI1PR04MB5327.eurprd04.prod.outlook.com>
Date:   Thu, 17 Jan 2019 07:01:21 +0000
From:   Peter Chen <peter.chen@....com>
To:     Philipp Puschmann <philipp.puschmann@...ix.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 1/2] dt-bindings: usb: ci-hdrc-usb2: add property
 power-active-high

 
> 
> The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity
> depends on the board. Reset state of the polarity is low-active so add this property
> to allow it to be high-active.
> 

As far as I know, most of i.mx USB controllers (except imx28/23, but they don't have non-core registers)
work like this, and most of them are low active for PP default. Would you just use "i.mx" at
both your code and your comment?

Peter

> Signed-off-by: Philipp Puschmann <philipp.puschmann@...ix.com>
> ---
> Changes in v3: add description
> ---
>  Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index adae82385dd6..8696e3eff6e7 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -93,6 +93,7 @@ i.mx specific properties
>  - over-current-active-low: over current signal polarity is active low.
>  - over-current-active-high: over current signal polarity is active high.
>    It's recommended to specify the over current polarity.
> +- power-active-high: power signal polarity is high active (only for
> +imx6q/dl)
>  - external-vbus-divider: enables off-chip resistor divider for Vbus
> 
>  Example:
> --
> 2.20.1