linux-kernel - RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Jan 2019 08:06:10 +0000
From:   Ran Wang <ran.wang_1@....com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Alan Stern <stern@...land.harvard.edu>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for
 arm/arm64 platforms

Hi Greg,

On 08, 2019 23:45, Greg Kroah-Hartman wrote:
> 
> On Tue, Jan 08, 2019 at 06:04:26AM +0000, Ran Wang wrote:
> > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(),
> > which causing compile failure on some Layerscape Platforms (such as
> > LS1021A and LS2012A which also integrates FSL EHCI controller). So use
> > ioread32be()/iowrite32be() instead to make it workable on both powerpc
> > and arm.
> 
> Shouldn't you have this patch before the Kconfig change, so that you do not
> break the build on ARM systems on that one and then fix it up on this one?

Yes, you are right, will adjust it in next version, thanks for pointing out.

Regards,
Ran