linux-kernel - Re: [PATCH v2 1/2] dt-bindings: rtc: Add bindings for Cadence RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190117120842.GB26715@piout.net>
Date:   Thu, 17 Jan 2019 13:08:42 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Jan Kotas <jank@...ence.com>
Cc:     Rob Herring <robh@...nel.org>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        Mark Rutland <mark.rutland@....com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: Add bindings for Cadence RTC

On 17/01/2019 10:46:50+0000, Jan Kotas wrote:
> 
> > On 16 Jan 2019, at 22:08, Rob Herring <robh@...nel.org> wrote:
> > 
> > 
> > On Fri, Jan 11, 2019 at 03:14:00PM +0000, Jan Kotas wrote:
> >> This patch adds a DT binding documentation for
> >> Cadence RTC controller.
> >> +Required properties:
> >> +- compatible: Should be "cdns,rtc-r109v3"
> >> +- reg: Specifies base physical address and size of the register area.
> >> +- interrupts: A single interrupt specifier.
> >> +- clocks: Must contain two entries:
> >> +	- pclk: APB registers clock
> >> +	- ref_clk: reference 1Hz of 100Hz clock, depending on IP configuration
> > 
> > 1Hz OR 100Hz?
> 
> Hi,
> 
> The IP has a configuration parameter at build time,
> which selects the reference clock frequency.
> 
> It cannot be changed later, and there’s no register which
> tells the software which option was selected.
> 
> In this version of the patch, both values are accepted.
> If it makes sense I can add a bool property, like
> refclock-100hz, which can be used to check the clock frequency.
> 

I guess what rob suggested was s/of/or/


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com