linux-kernel - Re: [PATCH v4 2/3] locking: Implement an algorithm choice for Wound-Wait mutexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGvLOKOScQFMHVAFweGDnbR1E3ORqzH6mymJ60rTXkZEfw@mail.gmail.com>
Date:   Thu, 17 Jan 2019 07:47:34 -0500
From:   Rob Clark <robdclark@...il.com>
To:     Thomas Hellstrom <thellstrom@...are.com>
Cc:     "corbet@....net" <corbet@....net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "dave@...olabs.net" <dave@...olabs.net>,
        "josh@...htriplett.org" <josh@...htriplett.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "seanpaul@...omium.org" <seanpaul@...omium.org>,
        Pv-drivers <Pv-drivers@...are.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "gustavo@...ovan.org" <gustavo@...ovan.org>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] locking: Implement an algorithm choice for
 Wound-Wait mutexes

On Wed, Jan 16, 2019 at 11:49 AM Thomas Hellstrom <thellstrom@...are.com> wrote:
>
> Hi,
>
> On Wed, 2019-01-16 at 09:24 -0500, Rob Clark wrote:
> > So, I guess this is to do w/ the magic of merge commits, but it looks
> > like the hunk changing the crtc_ww_class got lost:
>
> So what happened here is that this commit changed it to
> DEFINE_WD_CLASS
> and the following commit changed it back again to
> DEFINE_WW_CLASS
> so that the algorithm change and only that came with the last commit.
> Apparently the history of that line got lost when merging since the
> merge didn't change it; git blame doesn't show it changed, but when
> looking at the commit history in gitk it's all clear. I guess that's a
> feature of git.
>
> The modeset locks now use true wound-wait rather than wait-die.

ahh, ok, that makes sense.  Thanks for clearing up my confusion.

BR,
-R