linux-kernel - Re: [PATCH 0/3] tracing: probeevent: Fix probe argument parser and handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190117092302.596b4538@vmware.local.home>
Date:   Thu, 17 Jan 2019 09:23:02 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Andreas Ziegler <andreas.ziegler@....de>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] tracing: probeevent: Fix probe argument parser and
 handler

On Thu, 17 Jan 2019 22:47:58 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Hi,
> 
> This series fixes several bugs in probe event argument parser
> and handler routines.

Hi Masami,

Can you resend with a "Fixes:" tag to each of the patches, so that it
is easy to see what patch needs to be backported to which stable kernel
(or not any stable release if the patch fixes something in 5.0-rc).

Thanks!

-- Steve

> 
> Recently I got 2 issues reported by Andreas, see
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1899098.html
> 
> One issue is already fixed by Andreas (Thanks!) but $comm handling
> issue still exists on uprobe event. [1/3] fixes it.
> And I found other issues around that, [2/3] is just a trivial cleanup,
> [3/3] fixes $comm type issue which occurs not only uprobe events but
> also on kprobe events. Anyway, after this series applied, $comm must
> be "string" type and not be an array.
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (3):
>       tracing: uprobes: Re-enable $comm support for uprobe events
>       tracing: probeevent: Do not accumulate on ret variable
>       tracing: probeevent: Fix to make the type of $comm string
> 
> 
>  kernel/trace/trace_probe.c      |   13 +++++++------
>  kernel/trace/trace_probe_tmpl.h |    2 +-
>  kernel/trace/trace_uprobe.c     |   15 +++++++++++++--
>  3 files changed, 21 insertions(+), 9 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@...nel.org>