linux-kernel - Re: [PATCH] watchdog: qcom: Add suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190117143044.GA30757@roeck-us.net>
Date:   Thu, 17 Jan 2019 06:30:44 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
Cc:     Brian Masney <masneyb@...tation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org,
        Guenter Roeck <groeck@...omium.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        Sibi Sankar <sibis@...eaurora.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Doug Anderson <dianders@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] watchdog: qcom: Add suspend/resume support

On Thu, Jan 17, 2019 at 06:30:41PM +0530, Sai Prakash Ranjan wrote:
> On 1/17/2019 4:57 PM, Brian Masney wrote:
> >
> >That attribute suppresses a warning from the compiler if the function is
> >unused when PM_SLEEP is disabled.  I don't consider it hackish since the
> >function name no longer appears outside the #ifdef. For example:
> >
> >	#ifdef CONFIG_PM_SLEEP
> >	static int qcom_wdt_suspend(struct device *dev)
> >	{
> >		...
> >	}
> >	#endif /* CONFIG_PM_SLEEP */
> >
> >	static SIMPLE_DEV_PM_OPS(..., qcom_wdt_suspend, ...);
> >
> >SIMPLE_DEV_PM_OPS (actually SET_SYSTEM_SLEEP_PM_OP) includes the check
> >for PM_SLEEP and its a noop if PM_SLEEP is disabled so this works.
> >
> >Now here's the code with __maybe_unused:
> >
> >	static int __maybe_unused qcom_wdt_suspend(struct device *dev)
> >	{
> >		...
> >	}
> >
> >	static SIMPLE_DEV_PM_OPS(..., qcom_wdt_suspend, ...);
> >
> >This will still be a NOOP when power management is disabled, but have
> >the benefit of increased compile-time test coverage in that situation.
> >The symbols won't be included in the final executable. I personally
> >think the code a is cleaner with __maybe_unused.
> >
> >This pattern is already in use across various subsystems in the kernel
> >for suspend and resume functions:
> >
> >$ git grep __maybe_unused | egrep "_suspend|_resume"  | wc -l
> >767
> >
> 
> Thanks for the explanation Brian.
> 
> But I did see the maybe_unused attribute usage in other suspend and resume
> functions before posting and decided to go with ifdef because
> I think this attribute wastes CPU time by building and later discarding if
> the function is unused (it may be negligible).
> 
Your argument is that the increased build time test coverage, the improved
code readability, and the reduced risk of dependency errors are not worth
the additional compile time. You might want to take that up with the upstream
kernel community.

> I did not understand the increased compile-time test coverage
> you mentioned when PM_SLEEP=n because why would we need to compile
> when the config is disabled? We could just discard it. We would just

It is beneficial to know that a future change in the conditional code,
or an infrastructure change affecting it, doesn't cause a build error,
even if the person submitting the change didn't bother compiling with
PM_SLEEP=y.

> increase the build time with this attribute (although for this case it would
> be negligible but say we compile with PM_SLEEP disabled for all those
> suspend/resume functions with maybe_unused attribute).
> 
> Looking at previous discussions in LKML[1] as to why the pm suspend/resume
> functions used __maybe_unused seemes to be because of
> wrong ifdef usage. For ex: Using #ifdef CONFIG_PM instead of
> #ifdef CONFIG_PM_SLEEP would result in a warning when
> CONFIG_PM_SLEEP=n but CONFIG_PM=y.
> 

Do you realize that you are proving a point here, and that it isn't
your point ?

I personally very much prefer __maybe_unused over #ifdef, for the reasons
stated above. Other maintainers may think differently.

Guenter

> Anyways, *I am OK with either of them*, after some more review on the
> patch I can make the change in next version of the patch.
> 
> [1] https://lore.kernel.org/patchwork/patch/732981/
> 
> - Sai
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation