linux-kernel - Re: [PATCH 2/3] PCI: hv: Add vPCI version protocol negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190117145937.GE158366@google.com>
Date:   Thu, 17 Jan 2019 08:59:38 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ajay Kaher <akaher@...are.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com,
        devel@...uxdriverproject.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jork Loeser <jloeser@...rosoft.com>
Subject: Re: [PATCH 2/3] PCI: hv: Add vPCI version protocol negotiation

On Fri, Jan 18, 2019 at 02:17:17AM +0530, Ajay Kaher wrote:
> Hyper-V vPCI offers different protocol versions.  Add the infra for
> negotiating the one to use.
> 
> Signed-off-by: Jork Loeser <jloeser@...rosoft.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

I did not sign off on this, please remove.

> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
> Acked-by: K. Y. Srinivasan <kys@...rosoft.com>
> Signed-off-by: Ajay Kaher <akaher@...are.com>
> ---
>  drivers/pci/host/pci-hyperv.c | 72 +++++++++++++++++++++++++++++++------------
>  1 file changed, 53 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
> index 9e44adf..6eed85b 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -65,22 +65,37 @@
>   * major version.
>   */
>  
> -#define PCI_MAKE_VERSION(major, minor) ((u32)(((major) << 16) | (major)))
> +#define PCI_MAKE_VERSION(major, minor) ((u32)(((major) << 16) | (minor)))

This looks like a bug fix that should be in its own patch.