lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 17 Jan 2019 11:29:46 -0800
From:   Joe Perches <joe@...ches.com>
To:     Colin King <colin.king@...onical.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] rtlwifi: rtl818x: fix indentation issue

On Thu, 2019-01-17 at 15:28 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a statement that is indented too deeply. Fix this.

Thanks.

> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
[]
> @@ -803,7 +803,7 @@ static void rtl8180_config_cardbus(struct ieee80211_hw *dev)
>  		rtl818x_iowrite16(priv, FEMR_SE, 0xffff);
>  	} else {
>  		reg16 = rtl818x_ioread16(priv, &priv->map->FEMR);
> -			reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
> +		reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
>  		rtl818x_iowrite16(priv, &priv->map->FEMR, reg16);
>  	}

trivia:

It sure looks as if there could be some rather useful
conversions of magic bits to constants one day.



Powered by blists - more mailing lists