linux-kernel - Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f654f36-08de-f5e8-c9b3-ff9b2954f0a6@redhat.com>
Date:   Fri, 18 Jan 2019 12:48:03 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Liam Mark <lmark@...eaurora.org>, sumit.semwal@...aro.org
Cc:     arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        joel@...lfernandes.org, christian@...uner.io,
        devel@...verdev.osuosl.org, dri-devel@...ts.freedesktop.org,
        linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org,
        afd@...com, john.stultz@...aro.org
Subject: Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping
 attributes

On 1/18/19 10:37 AM, Liam Mark wrote:
> Add support for configuring dma mapping attributes when mapping
> and unmapping memory through dma_buf_map_attachment and
> dma_buf_unmap_attachment.
> 
> Signed-off-by: Liam Mark <lmark@...eaurora.org>
> ---
>   include/linux/dma-buf.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
> index 58725f890b5b..59bf33e09e2d 100644
> --- a/include/linux/dma-buf.h
> +++ b/include/linux/dma-buf.h
> @@ -308,6 +308,8 @@ struct dma_buf {
>    * @dev: device attached to the buffer.
>    * @node: list of dma_buf_attachment.
>    * @priv: exporter specific attachment data.
> + * @dma_map_attrs: DMA mapping attributes to be used in
> + *		   dma_buf_map_attachment() and dma_buf_unmap_attachment().
>    *
>    * This structure holds the attachment information between the dma_buf buffer
>    * and its user device(s). The list contains one attachment struct per device
> @@ -323,6 +325,7 @@ struct dma_buf_attachment {
>   	struct device *dev;
>   	struct list_head node;
>   	void *priv;
> +	unsigned long dma_map_attrs;
>   };
>   
>   /**
> 

Did you miss part of this patch? This only adds it to the structure but doesn't
add it to any API. The same commment applies to the follow up patch,
I don't quite see how it's being used.

Thanks,
Laura