[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190118220417.GE4140@jcrouse1-lnx.qualcomm.com>
Date: Fri, 18 Jan 2019 15:04:17 -0700
From: Jordan Crouse <jcrouse@...eaurora.org>
To: Doug Anderson <dianders@...omium.org>
Cc: Georgi Djakov <georgi.djakov@...aro.org>,
Rob Clark <robdclark@...il.com>,
Evan Green <evgreen@...omium.org>,
Kees Cook <keescook@...omium.org>,
Jonathan Marek <jonathan@...ek.ca>,
David Airlie <airlied@...ux.ie>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
Sharat Masetty <smasetty@...eaurora.org>,
LKML <linux-kernel@...r.kernel.org>,
dri-devel <dri-devel@...ts.freedesktop.org>,
Stephen Boyd <swboyd@...omium.org>,
Mamta Shukla <mamtashukla555@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Andy Gross <andy.gross@...aro.org>,
Colin Ian King <colin.king@...onical.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
freedreno <freedreno@...ts.freedesktop.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [Freedreno] [PATCH v6] drm/msm/a6xx: Add support for an
interconnect path
On Fri, Jan 18, 2019 at 01:52:20PM -0800, Doug Anderson wrote:
> Hi,
>
> On Fri, Jan 18, 2019 at 12:24 PM Jordan Crouse <jcrouse@...eaurora.org> wrote:
> >
> > Try to get the interconnect path for the GPU and vote for the maximum
> > bandwidth to support all frequencies. This is needed for performance.
> > Later we will want to scale the bandwidth based on the frequency to
> > also optimize for power but that will require some device tree
> > infrastructure that does not yet exist.
> >
> > v6: use icc_set_bw() instead of icc_set()
> > v5: Remove hardcoded interconnect name and just use the default
> > v4: Don't use a port string at all to skip the need for names in the DT
> > v3: Use macros and change port string per Georgi Djakov
> >
> > Signed-off-by: Jordan Crouse <jcrouse@...eaurora.org>
> > ---
> >
> > drivers/gpu/drm/msm/Kconfig | 1 +
> > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 20 ++++++++++++++++++++
> > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 +++++++++
> > drivers/gpu/drm/msm/msm_gpu.h | 3 +++
> > 4 files changed, 33 insertions(+)
>
> Presumably this should go in together with the bindings:
>
> - https://patchwork.kernel.org/patch/10739233/
> - https://lkml.kernel.org/r/20181220173026.3857-3-jcrouse@codeaurora.org
>
> ...since bindings and code usually go in the same tree together.
>
>
> As per discussion in v3 AKA v5
> <https://patchwork.kernel.org/patch/10739231/>, we're trying to figure
> out where to land this. ;-)
I'm just a simple caveman driver developer. I'll let the adults figure
out where to put what. LMK if you need a rebase on a different tree.
Jordan
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Powered by blists - more mailing lists