linux-kernel - Re: [v8, 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Jan 2019 01:40:03 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Heiko Stuebner <heiko@...ech.de>
cc:     hjc@...k-chips.com, linux-rockchip@...ts.infradead.org,
        seanpaul@...omium.org, LKML <linux-kernel@...r.kernel.org>,
        dri-devel@...ts.freedesktop.org,
        Greg KH <gregkh@...uxfoundation.org>,
        Kate Stewart <kstewart@...uxfoundation.org>
Subject: Re: [v8, 2/3] drm/rockchip: Add support for Rockchip Soc RGB output
 interface

Sandy, Heiko,

On Thu, 30 Aug 2018, Heiko Stuebner wrote:

> +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c
> @@ -0,0 +1,173 @@
> +//SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
> + * Author:
> + *      Sandy Huang <hjc@...k-chips.com>
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

The licensing in this file and in the corresponding header is broken.

> --- /dev/null
> +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.h
> @@ -0,0 +1,20 @@
> +//SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
> + * Author:
> + *      Sandy Huang <hjc@...k-chips.com>
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Both files use the SPDX license identifier for GPL v2 or later, but the
license notice is clearly v2 only.

So the copyright holder needs to decide which one. And please remove the
boiler plate text. It's redundant.

See also Documentation/process/license-rules.rst

Please fix ASAP, add a Fixes tag and cc stable so the inconsistency is
fixed in 4.20 as well.

Thanks,

	tglx