[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7d387d2a-74f0-c6c7-aa2d-cf9b87579682@gmail.com>
Date: Fri, 18 Jan 2019 09:44:49 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: Ryder Lee <ryder.lee@...iatek.com>,
Thierry Reding <thierry.reding@...il.com>
Cc: Sean Wang <sean.wang@...nel.org>,
Weijie Gao <weijie.gao@...iatek.com>,
linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v1 2/5] dt-bindings: pwm: add a property
"mediatek,num-pwms"
On 18/01/2019 04:24, Ryder Lee wrote:
> This adds a property "mediatek,num-pwms" in example so that we could
> set the number of PWM channels via device tree.
>
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> ---
> Changes since v1: add a Reviewed-by tag.
> ---
> Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> index 991728c..f9e2d1f 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> @@ -20,6 +20,7 @@ Required properties:
> - pinctrl-names: Must contain a "default" entry.
> - pinctrl-0: One property must exist for each entry in pinctrl-names.
> See pinctrl/pinctrl-bindings.txt for details of the property values.
> + - mediatek,num-pwms: the number of PWM channels.
>
> Example:
> pwm0: pwm@...06000 {
> @@ -37,4 +38,5 @@ Example:
> "pwm3", "pwm4", "pwm5";
> pinctrl-names = "default";
> pinctrl-0 = <&pwm0_pins>;
> + mediatek,num-pwms = <5>;
> };
>
Wasn't there a comment in the last version to use num-pwms instead of
mediatek,num-pwms?
Uwe I think you requested that.
Regards,
Matthias
Powered by blists - more mailing lists