| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <bdd3ec10-1f9f-324c-aed0-6eab30fe518b@baylibre.com>
Date: Fri, 18 Jan 2019 10:40:17 +0100
From: Neil Armstrong <narmstrong@...libre.com>
To: Andrzej Hajda <a.hajda@...sung.com>,
Laurent.pinchart@...asonboard.com
Cc: linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/8] drm/meson: add HDMI div40 TMDS mode
Hi Andrzej,
On 18/01/2019 10:13, Andrzej Hajda wrote:
> On 15.01.2019 13:33, Neil Armstrong wrote:
>> Add support for TMDS Clock > 3.4GHz for HDMI2.0 display modes.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>> ---
>> drivers/gpu/drm/meson/meson_dw_hdmi.c | 23 +++++++++++++++++++----
>> 1 file changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
>> index 807111ebfdd9..3d8decb77019 100644
>> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
>> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
>> @@ -365,7 +365,8 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
>> unsigned int wr_clk =
>> readl_relaxed(priv->io_base + _REG(VPU_HDMI_SETTING));
>>
>> - DRM_DEBUG_DRIVER("%d:\"%s\"\n", mode->base.id, mode->name);
>> + DRM_DEBUG_DRIVER("%d:\"%s\" div%d\n", mode->base.id, mode->name,
>> + mode->clock > 340000 ? 40 : 10);
>>
>> /* Enable clocks */
>> regmap_update_bits(priv->hhi, HHI_HDMI_CLK_CNTL, 0xffff, 0x100);
>> @@ -385,9 +386,17 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
>> /* Enable normal output to PHY */
>> dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_BIST_CNTL, BIT(12));
>>
>> - /* TMDS pattern setup (TOFIX pattern for 4k2k scrambling) */
>> - dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01, 0x001f001f);
>> - dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23, 0x001f001f);
>> + /* TMDS pattern setup (TOFIX Handle the YUV420 case) */
>> + if (mode->clock > 340000) {
>> + dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01, 0);
>> + dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23,
>> + 0x03ff03ff);
>> + } else {
>> + dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01,
>> + 0x001f001f);
>> + dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23,
>> + 0x001f001f);
>> + }
>
>
> val = mode->clock > 340000 ? 0x03ff03ff : 0x001f001f;
> dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01, val);
>
> dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23, val);
>
>
> The best would be to replace these magic values with descriptive macros.
In fact, these are patterns, not sure how to describe them ? it's like a plain number, the value has it's own meaning.
Neil
>
>
> Regards
>
> Andrzej
>
>
>>
>> /* Load TMDS pattern */
>> dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_CNTL, 0x1);
>> @@ -413,6 +422,8 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
>> /* Disable clock, fifo, fifo_wr */
>> regmap_update_bits(priv->hhi, HHI_HDMI_PHY_CNTL1, 0xf, 0);
>>
>> + dw_hdmi_set_high_tmds_clock_ratio(hdmi);
>> +
>> msleep(100);
>>
>> /* Reset PHY 3 times in a row */
>> @@ -562,6 +573,10 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
>> mode->vdisplay, mode->vsync_start,
>> mode->vsync_end, mode->vtotal, mode->type, mode->flags);
>>
>> + /* If sink max TMDS clock, we reject the mode */
>> + if (mode->clock > connector->display_info.max_tmds_clock)
>> + return MODE_BAD;
>> +
>> /* Check against non-VIC supported modes */
>> if (!vic) {
>> status = meson_venc_hdmi_supported_mode(mode);
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Powered by blists - more mailing lists