linux-kernel - Re: [PATCH] crypto: testmgr - split akcipher tests by a key type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190118105645.w7hpezhdsme7lzev@gondor.apana.org.au>
Date:   Fri, 18 Jan 2019 18:56:45 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Vitaly Chikunov <vt@...linux.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: testmgr - split akcipher tests by a key type

On Mon, Jan 07, 2019 at 08:54:27PM +0300, Vitaly Chikunov wrote:
> Before this, if akcipher_testvec have `public_key_vec' set to true
> (i.e. having a public key) only sign/encrypt test is performed, but
> verify/decrypt test is skipped.
> 
> With a public key we could do encrypt and verify, but to sign and decrypt
> a private key is required.
> 
> This logic is correct for encrypt/decrypt tests (decrypt is skipped if
> no private key). But incorrect for sign/verify tests - sign is performed
> no matter if there is no private key, but verify is skipped if there is
> a public key.
> 
> Rework `test_akcipher_one' to arrange tests properly depending on value
> of `public_key_vec` and `siggen_sigver_test'.
> 
> No tests were missed since there is only one sign/verify test (which
> have `siggen_sigver_test' set to true) and it has a private key, but
> future tests could benefit from this improvement.
> 
> Signed-off-by: Vitaly Chikunov <vt@...linux.org>
> ---
>  crypto/testmgr.c | 86 +++++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 57 insertions(+), 29 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt