linux-kernel - Re: [PATCH] bluetooth: hci_bcm: Check for driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <A6573C2B-CEA7-4B48-B812-B76D01E175AC@holtmann.org>
Date:   Fri, 18 Jan 2019 11:59:28 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Aditya Pakki <pakki001@....edu>
Cc:     kjlu@....edu, Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bluetooth: hci_bcm: Check for driver_register failure

Hi Aditya,

> While initializing the driver, the function platform_driver_register can
> fail and return an error. Consistent with other invocations, this patch
> returns the error upstream.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
> drivers/bluetooth/hci_bcm.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index ddbe518c3e5b..f5ddb0f19c31 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1442,7 +1442,12 @@ int __init bcm_init(void)
> 	/* For now, we need to keep both platform device
> 	 * driver (ACPI generated) and serdev driver (DT).
> 	 */
> -	platform_driver_register(&bcm_driver);
> +	int rc;
> +
> +	rc = platform_driver_register(&bcm_driver);
> +	if (rc)
> +		return rc;
> +

actually I am fine with ignoring the error here since the usage of a platform device should be removed at some point. It was sort of a hack before we had proper ACPI integration and serdev support.

Regards

Marcel