linux-kernel - Re: [PATCH 6/7] sctp: Convert to genradix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190118131022.GA22165@hmswarspite.think-freely.org>
Date:   Fri, 18 Jan 2019 08:10:22 -0500
From:   Neil Horman <nhorman@...driver.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     Kent Overstreet <kent.overstreet@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevich@...il.com>,
        linux-sctp@...r.kernel.org
Subject: Re: [PATCH 6/7] sctp: Convert to genradix

On Tue, Jan 15, 2019 at 12:29:26PM -0200, Marcelo Ricardo Leitner wrote:
> On Mon, Dec 17, 2018 at 04:00:21PM -0500, Kent Overstreet wrote:
> > On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote:
> > > On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet <kent.overstreet@...il.com> wrote:
> > > 
> > > > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc,
> > > >  		goto out;
> > > >  	}
> > > >  
> > > > -	stream->incnt = incnt;
> > > > -	stream->outcnt = outcnt;
> > > > -
> > > >  	asoc->strreset_outstanding = !!out + !!in;
> > > >  
> > > 
> > > I'm seeing a reject here for some reason.  Using todays's linux-next,
> > > but there are no changes against net/sctp/stream.c in -next.  The
> > > assignment to stream->incnt has disappeared.  I did this:
> > > 
> > > @@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as
> > >  		goto out;
> > >  	}
> > >  
> > > -	stream->outcnt = outcnt;
> > > -
> > >  	asoc->strreset_outstanding = !!out + !!in;
> > >  
> > >  out:
> > > 
> > > 
> > > We're at 4.20-rc7 and this series is rather large.  I'll merge them all
> > > to see what happens, but I don't think it's 4.21-rc1 material?
> > 
> > Yeah, agreed. Thanks!
> 
> Ping? Where did this go?
> 
As I recall kent reposted his series convirting flex_arrays to radix trees such
that it included sctp's uses.

I think xin needs to repost the sctp reallocation patch to make use of those
radix trees appropriately still (assuming any additional work still needs to be
done)

Neil

>   Marcelo
>