linux-kernel - Re: [PATCH 3/3] phy: make phy-armada375-usb2 explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Jan 2019 15:44:27 +0100
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        <linux-kernel@...r.kernel.org>,
        Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH 3/3] phy: make phy-armada375-usb2 explicitly non-modular

Hi Paul,
 
 On dim., déc. 09 2018, Paul Gortmaker <paul.gortmaker@...driver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/phy/marvell/Kconfig:config ARMADA375_USBCLUSTER_PHY
> drivers/phy/marvell/Kconfig:    def_bool y
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple of traces of modular infrastructure, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Gregory CLEMENT <gregory.clement@...e-electrons.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Reviewed-by: Gregory CLEMENT <gregory.clement@...tlin.com>

Thanks,

Gregory

> ---
>  drivers/phy/marvell/phy-armada375-usb2.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-armada375-usb2.c b/drivers/phy/marvell/phy-armada375-usb2.c
> index 1a3db288c0a9..4f0295992500 100644
> --- a/drivers/phy/marvell/phy-armada375-usb2.c
> +++ b/drivers/phy/marvell/phy-armada375-usb2.c
> @@ -18,7 +18,6 @@
>  #include <linux/init.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
> -#include <linux/module.h>
>  #include <linux/of_address.h>
>  #include <linux/phy/phy.h>
>  #include <linux/platform_device.h>
> @@ -142,7 +141,6 @@ static const struct of_device_id of_usb_cluster_table[] = {
>  	{ .compatible = "marvell,armada-375-usb-cluster", },
>  	{ /* end of list */ },
>  };
> -MODULE_DEVICE_TABLE(of, of_usb_cluster_table);
>  
>  static struct platform_driver armada375_usb_phy_driver = {
>  	.probe	= armada375_usb_phy_probe,
> @@ -151,8 +149,4 @@ static struct platform_driver armada375_usb_phy_driver = {
>  		.name  = "armada-375-usb-cluster",
>  	}
>  };
> -module_platform_driver(armada375_usb_phy_driver);
> -
> -MODULE_DESCRIPTION("Armada 375 USB cluster driver");
> -MODULE_AUTHOR("Gregory CLEMENT <gregory.clement@...e-electrons.com>");
> -MODULE_LICENSE("GPL");
> +builtin_platform_driver(armada375_usb_phy_driver);
> -- 
> 2.7.4
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com