[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190118025800.GB737@sol.localdomain>
Date: Thu, 17 Jan 2019 18:58:01 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net,
linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
broonie@...nel.org, ard.biesheuvel@...aro.org,
jonathan.cameron@...wei.com
Subject: Re: [PATCH V2 4/5] crypto: ctr - use template array registering API
to simplify the code
On Thu, Jan 17, 2019 at 02:48:02PM +0800, Xiongfeng Wang wrote:
> Use crypto template array registering API to simplify the code.
>
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@...aro.org>
> ---
> crypto/ctr.c | 43 +++++++++++++++----------------------------
> 1 file changed, 15 insertions(+), 28 deletions(-)
>
> diff --git a/crypto/ctr.c b/crypto/ctr.c
> index 4c743a9..d9f9d65 100644
> --- a/crypto/ctr.c
> +++ b/crypto/ctr.c
> @@ -171,12 +171,6 @@ static int crypto_ctr_create(struct crypto_template *tmpl, struct rtattr **tb)
> return err;
> }
>
> -static struct crypto_template crypto_ctr_tmpl = {
> - .name = "ctr",
> - .create = crypto_ctr_create,
> - .module = THIS_MODULE,
> -};
> -
> static int crypto_rfc3686_setkey(struct crypto_skcipher *parent,
> const u8 *key, unsigned int keylen)
> {
> @@ -366,36 +360,29 @@ static int crypto_rfc3686_create(struct crypto_template *tmpl,
> goto out;
> }
>
> -static struct crypto_template crypto_rfc3686_tmpl = {
> - .name = "rfc3686",
> - .create = crypto_rfc3686_create,
> - .module = THIS_MODULE,
> +static struct crypto_template crypto_ctr_tmpls[] = {
> + {
> + .name = "ctr",
> + .create = crypto_ctr_create,
> + .module = THIS_MODULE,
> + }, {
> + .name = "rfc3686",
> + .create = crypto_rfc3686_create,
> + .module = THIS_MODULE,
> + },
> };
>
> +
If you resend please also remove the extra blank line here.
- Eric
Powered by blists - more mailing lists