linux-kernel - Re: [PATCH/RFC] Make perf_event_open() propagate errors for use in bpf_perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190118161959.GI14054@worktop.programming.kicks-ass.net>
Date:   Fri, 18 Jan 2019 17:19:59 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Clark Williams <williams@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Networking Development Mailing List 
        <netdev@...r.kernel.org>
Subject: Re: [PATCH/RFC] Make perf_event_open() propagate errors for use in
 bpf_perf_event_open()

On Fri, Jan 18, 2019 at 12:09:38PM -0300, Arnaldo Carvalho de Melo wrote:
> commit 1b3b3dee572d0b77a316ab6715091201be6832de
> Author: Arnaldo Carvalho de Melo <acme@...hat.com>
> Date:   Fri Jan 11 13:20:20 2019 -0300
> 
>     perf: Make perf_event_output() propagate the output() return
>     
>     For the original mode of operation it isn't needed, since we report back
>     errors via PERF_RECORD_LOST records in the ring buffer, but for use in
>     bpf_perf_event_output() it is convenient to return the errors, basically
>     -ENOSPC.
>     
>     Currently bpf_perf_event_output() returns an error indication, the last
>     thing it does, which is to push it to the ring buffer is that can fail
>     and if so, this failure won't be reported back to its users, fix it.
>     
>     Reported-by: Jamal Hadi Salim <jhs@...atatu.com>
>     Tested-by: Jamal Hadi Salim <jhs@...atatu.com>
>     Cc: Adrian Hunter <adrian.hunter@...el.com>
>     Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>
>     Cc: Daniel Borkmann <daniel@...earbox.net>
>     Cc: Jiri Olsa <jolsa@...nel.org>
>     Cc: Namhyung Kim <namhyung@...nel.org>
>     Cc: Peter Zijlstra <peterz@...radead.org>
>     Link: https://lkml.kernel.org/r/20190111155538.GX22483@kernel.org
>     Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

/me hates on git-format :-)

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>