linux-kernel - Re: linux-next: Fixes tag needs some work in the clk tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154783304655.169631.12906027462791855701@swboyd.mtv.corp.google.com>
Date:   Fri, 18 Jan 2019 09:37:26 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Fabio Estevam <festevam@...il.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Joe Perches <joe@...ches.com>
Cc:     Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: linux-next: Fixes tag needs some work in the clk tree

Quoting Michael Ellerman (2019-01-18 04:41:41)
> Stephen Boyd <sboyd@...nel.org> writes:
> 
> > Quoting Fabio Estevam (2019-01-16 17:25:21)
> >> On Wed, Jan 16, 2019 at 10:44 PM Stephen Boyd <sboyd@...nel.org> wrote:
> >> 
> >> > Ok sure. Does this matter to scripts? Is it documented in
> >> > Documentation/process/submitting-patches.rst? I've seen both types, one
> >> 
> >> From Documentation/process/submitting-patches.rst"
> >> 
> >> "If your patch fixes a bug in a specific commit, e.g. you found an issue using
> >> ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
> >> the SHA-1 ID, and the one line summary.  For example::
> >> 
> >> Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")"
> >
> > Yes but 'one line summary' is not clear to me. Does it mean the summary
> > line? Or the one line summary on one line regardless of commit message
> > column wrapping? Sorry to be pedantic but I can see how this can be
> > misunderstood.
> 
> Yeah "one line summary" is referring to the subject of the commit.
> 
> So it doesn't explicitly say not to split it across lines, it probably
> should.
> 
> eg: ?

Yes, thanks!

> 
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 30dc00a364e8..12a283ba3929 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -186,6 +186,8 @@ If your patch fixes a bug in a specific commit, e.g. you found an issue using
>  
>         Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
>  
> +To ease parsing of the 'Fixes:' tag please don't split it across multiple lines.
> +
>  The following ``git config`` settings can be used to add a pretty format for
>  outputting the above style in the ``git log`` or ``git show`` commands::
>  
> 

Reviewed-by: Stephen Boyd <sboyd@...nel.org>

Do you have a patch for checkpatch too? Maybe Joe can solve my problem.