linux-kernel - Re: [PATCH] um: Remove duplicate headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfdf5e70-f782-d90e-1059-a524a5e72b7d@cambridgegreys.com>
Date:   Fri, 18 Jan 2019 19:23:07 +0000
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Sabyasachi Gupta <sabyasachi.linux@...il.com>, jdike@...toit.com,
        richard@....at, yuehaibing@...wei.com
Cc:     brajeswar.linux@...il.com, linux-um@...ts.infradead.org,
        jrdr.linux@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: Remove duplicate headers



On 18/01/2019 14:58, Sabyasachi Gupta wrote:
> Remove sys/socket.h and sys/uio.h which are included more than once
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> ---
>   arch/um/drivers/vector_user.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
> index d2c17dd..c863921 100644
> --- a/arch/um/drivers/vector_user.c
> +++ b/arch/um/drivers/vector_user.c
> @@ -23,7 +23,6 @@
>   #include <netinet/ether.h>
>   #include <linux/if_ether.h>
>   #include <linux/if_packet.h>
> -#include <sys/socket.h>
>   #include <sys/wait.h>
>   #include <sys/uio.h>
>   #include <linux/virtio_net.h>
> @@ -31,7 +30,6 @@
>   #include <stdlib.h>
>   #include <os.h>
>   #include <um_malloc.h>
> -#include <sys/uio.h>
>   #include "vector_user.h"
>   
>   #define ID_GRE 0
> 

Hi Sabyasachi,

I believe we have an identical patch enqueued already from a couple of 
weeks back.

Best Regards,

A.