linux-kernel - Re: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190118200831.GB11798@Asurada-Nvidia.nvidia.com>
Date:   Fri, 18 Jan 2019 12:08:32 -0800
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     Daniel Baluta <daniel.baluta@....com>
Cc:     "broonie@...nel.org" <broonie@...nel.org>,
        "Xiubo.Lee@...il.com" <Xiubo.Lee@...il.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "S.j. Wang" <shengjiu.wang@....com>,
        dl-linux-imx <linux-imx@....com>,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler

On Fri, Jan 18, 2019 at 02:26:46PM +0000, Daniel Baluta wrote:
> From: Shengjiu Wang <shengjiu.wang@....com>
> 
> When stopping audio, ASoC will first stop DMA then CPU DAI.
> Sometimes there is a delay between DMA stop and CPU DAI stop, which
> triggers an underrun error. Now, because of the delay introduced
> by dev_err another underrun error will occur causing a vicious circle
> making impossible to stop CPU DAI.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>

Acked-by: Nicolin Chen <nicoleotsuka@...il.com>

> ---
>  sound/soc/fsl/fsl_sai.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 4163f2cfc06f..db9e0872f73d 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
>  		dev_dbg(dev, "isr: Start of Tx word detected\n");
>  
>  	if (flags & FSL_SAI_CSR_SEF)
> -		dev_warn(dev, "isr: Tx Frame sync error detected\n");
> +		dev_dbg(dev, "isr: Tx Frame sync error detected\n");
>  
>  	if (flags & FSL_SAI_CSR_FEF) {
> -		dev_warn(dev, "isr: Transmit underrun detected\n");
> +		dev_dbg(dev, "isr: Transmit underrun detected\n");
>  		/* FIFO reset for safety */
>  		xcsr |= FSL_SAI_CSR_FR;
>  	}
> @@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
>  		dev_dbg(dev, "isr: Start of Rx word detected\n");
>  
>  	if (flags & FSL_SAI_CSR_SEF)
> -		dev_warn(dev, "isr: Rx Frame sync error detected\n");
> +		dev_dbg(dev, "isr: Rx Frame sync error detected\n");
>  
>  	if (flags & FSL_SAI_CSR_FEF) {
> -		dev_warn(dev, "isr: Receive overflow detected\n");
> +		dev_dbg(dev, "isr: Receive overflow detected\n");
>  		/* FIFO reset for safety */
>  		xcsr |= FSL_SAI_CSR_FR;
>  	}
> -- 
> 2.17.1
>