linux-kernel - Re: [PATCH 1/5] RISC-V: Move free_initrd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhSdy3+aVMyXdECYwTp6=T9DyenEg4Q2uEhmJtfUJDokFbRWg@mail.gmail.com>
Date:   Sat, 19 Jan 2019 16:04:43 +0530
From:   Anup Patel <anup@...infault.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Anup Patel <anup.patel@....com>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>,
        Atish Patra <atish.patra@....com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 1/5] RISC-V: Move free_initrd_mem() to kernel/setup.c

On Tue, Jan 15, 2019 at 7:13 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Mon, Jan 07, 2019 at 09:40:43PM +0530, Anup Patel wrote:
> > From: Anup Patel <anup.patel@....com>
> >
> > We move free_initrd_mem() to kernel/setup.c so that all initrd
> > related functions are in one place.
> >
> > Signed-off-by: Anup Patel <anup.patel@....com>
>
> Looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@....de>
>
> Talking about free_initrd_mem - don't we need to call free_reserved_area
> to actually release the memory?

Yes, we should. Thanks for pointing.

I will include separate patch for it.

Thanks,
Anup