linux-kernel - Re: [PATCH net v2] net: phy: phy driver features are mandatory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190119.100446.2276221483557449324.davem@davemloft.net>
Date:   Sat, 19 Jan 2019 10:04:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     camelia.groza@....com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        oss@...error.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: phy: phy driver features are mandatory

From: Camelia Groza <camelia.groza@....com>
Date: Thu, 17 Jan 2019 14:22:36 +0200

> Since phy driver features became a link_mode bitmap, phy drivers that
> don't have a list of features configured will cause the kernel to crash
> when probed.
> 
> Prevent the phy driver from registering if the features field is missing.
> 
> Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap")
> Reported-by: Scott Wood <oss@...error.net>
> Signed-off-by: Camelia Groza <camelia.groza@....com>
> ---
> v2: Print the name of the driver that has missing features.
> 
> This patch should be merged to 4.20 stable.

Applied and queued up for -stable.