linux-kernel - Re: [PATCH v2] perf scripts python: Add Python 3 support to sctop.py

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba5edf49-a143-7a8c-c3f9-c1d8c3ceed0e@suse.de>
Date:   Fri, 18 Jan 2019 17:27:38 -0800
From:   Tony Jones <tonyj@...e.de>
To:     Seeteena Thoufeek <s1seetee@...ux.vnet.ibm.com>,
        peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perf scripts python: Add Python 3 support to sctop.py

On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:

> +from __future__ import print_function

Again, you don't need this.


> -			print "\nsyscall events for %s:\n\n" % (for_comm),
> +			print("\nsyscall events for %s:\n\n" % (for_comm)),

same comments regarding trailing comma usage

$ git annotate tools/perf/scripts/python/sctop.py | grep thread
2e7d1e3fb8043	(Arnaldo Carvalho de Melo	2010-10-25 18:39:20 -0200	11)import os, sys, thread, time
47902f3611b39	(Tom Zanussi	2010-04-01 23:59:23 -0500	42)	thread.start_new_thread(print_syscall_totals, (interval,))

The low level threading api has changed in the most recent Python versions.   I think you'll find you also need:

@@ -8,7 +8,12 @@
 # will be refreshed every [interval] seconds.  The default interval is
 # 3 seconds.

-import os, sys, thread, time
+import os, sys, time
+
+try:
+        import thread
+except ImportError:
+        import _thread as thread



Tony