linux-kernel - Re: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.999.1901190140510.8813@utopia.booyaka.com>
Date:   Sat, 19 Jan 2019 01:43:58 +0000 (UTC)
From:   Paul Walmsley <paul@...an.com>
To:     Johan Hovold <johan@...nel.org>
cc:     Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Andreas Schwab <schwab@...e.de>, linux-kernel@...r.kernel.org,
        Atish Patra <atish.patra@....com>,
        Anup Patel <anup@...infault.org>,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as
 enabled

On Fri, 18 Jan 2019, Johan Hovold wrote:

> Follow the Linux convention and treat devicetree nodes without a status
> property as enabled rather than disabled, while also allowing "ok" as a
> shorthand for "okay".
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Paul Walmsley <paul.walmsley@...ive.com>

... although I probably would have phrased the commit message slightly 
differently - something like "Use of_device_is_available() in 
riscv_of_processor_hartid(), in place of an open-coded test."  That frames 
the change as one that removes custom code in place of an existing 
standard function for the same purpose.


- Paul