linux-kernel - Re: [PATCH] perf top: Fix wrong hottest instruction highlighted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190120184043.GD8591@krava>
Date:   Sun, 20 Jan 2019 19:40:43 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     He Kuang <hekuang@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf top: Fix wrong hottest instruction highlighted

On Mon, Jan 21, 2019 at 12:05:22AM +0800, He Kuang wrote:
> Annotation line's percentage is compared and inserted into rbtree, but the
> percent field of 'struct annotation_data' is an array, the comparison
> result between them is the address difference.
> 
> This patch compares the right slot of percent array according to
> opts->percent_type and makes things right.
> 
> The problem can be reproduced by pressing 'H' in perf top annotation view.
> It should highlight the instruction line which has the highest sampling
> percentage.
> 
> Signed-off-by: He Kuang <hekuang@...wei.com>

Reviewed-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka