linux-kernel - Re: [PATCH v2 1/2] dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190120051405.GI4635@vkoul-mobl>
Date:   Sun, 20 Jan 2019 10:44:05 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Shunyong Yang <shunyong.yang@...-semitech.com>
Cc:     okaya@...nel.org, andy.gross@...aro.org, david.brown@...aro.org,
        dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Joey Zheng <yu.zheng@...-semitech.com>
Subject: Re: [PATCH v2 1/2] dmaengine: qcom_hidma: initialize tx flags in
 hidma_prep_dma_*

On 07-01-19, 09:32, Shunyong Yang wrote:
> In async_tx_test_ack(), it uses flags in struct dma_async_tx_descriptor
> to check the ACK status. As hidma reuses the descriptor in a free list
> when hidma_prep_dma_*(memcpy/memset) is called, the flag will keep ACKed
> if the descriptor has been used before. This will cause a BUG_ON in
> async_tx_quiesce().
> 
>   kernel BUG at crypto/async_tx/async_tx.c:282!
>   Internal error: Oops - BUG: 0 1 SMP
>   ...
>   task: ffff8017dd3ec000 task.stack: ffff8017dd3e8000
>   PC is at async_tx_quiesce+0x54/0x78 [async_tx]
>   LR is at async_trigger_callback+0x98/0x110 [async_tx]
> 
> This patch initializes flags in dma_async_tx_descriptor by the flags
> passed from the caller when hidma_prep_dma_*(memcpy/memset) is called.

Applied both, thanks

-- 
~Vinod