linux-kernel - Re: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <353a011e-920a-ddb3-4eef-e3256555ac93@microchip.com>
Date:   Sun, 20 Jan 2019 15:28:41 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <vigneshr@...com>, <bbrezillon@...nel.org>
CC:     <marek.vasut@...il.com>, <robh+dt@...nel.org>,
        <linux-mtd@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for
 Octal SPI controller

Vignesh,

On 01/20/2019 04:56 PM, Tudor.Ambarus@...rochip.com wrote:
> Looks good.

one more thing: in cqspi_read_setup() I see that the dummy cycles are adjusted
if (f_pdata->inst_width != CQSPI_INST_TYPE_QUAD).

Should you adjust the dummy cycles for octo too? I tried to find a datasheet for
the controller, without success though ...

ta