linux-kernel - Re: [PATCH 4.20 000/111] 4.20.4-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Jan 2019 16:38:11 +0100
From:   Ian Kumlien <ian.kumlien@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4.20 000/111] 4.20.4-stable review

Hi David,

could we have your blessing to add the following patch to -stable for 4.20.4:
commit 41d1c8839e5f8cb781cc635f12791decee8271b7
Author: Paolo Abeni <pabeni@...hat.com>
Date:   Tue Jan 8 18:45:05 2019 +0100

    net: clear skb->tstamp in bridge forwarding path

    Matteo reported forwarding issues inside the linux bridge,
    if the enslaved interfaces use the fq qdisc.

    Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
    forwarding paths"), we need to clear the tstamp field in
    the bridge forwarding path.

    Fixes: 80b14dee2bea ("net: Add a new socket option for a future
transmit time.")
    Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
    Reported-and-tested-by: Matteo Croce <mcroce@...hat.com>
    Signed-off-by: Paolo Abeni <pabeni@...hat.com>
    Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
    Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>
    Reviewed-by: Eric Dumazet <edumazet@...gle.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>
---

Also, do you keep your -stable queue somewhere where I can see it?
It feels like I'm stepping on toes, adding overhead and such, which is
not what i want...

On Mon, Jan 21, 2019 at 4:10 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> On Mon, Jan 21, 2019 at 03:56:24PM +0100, Ian Kumlien wrote:
> > On Mon, Jan 21, 2019 at 3:47 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> > > On Mon, Jan 21, 2019 at 03:44:24PM +0100, Ian Kumlien wrote:
> > > > Hi,
> > > >
> > > > IMHO you are missing: 41d1c8839e5f8cb781cc635f12791decee8271b7
> > > >
> > > > Which should be marked for stable, it fixes:
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=202235
> > >
> > > The networking maintainer handles sending those patches to me.  It
> > > wasn't part of the last set of patches, so perhaps it will be in the
> > > next one?
> >
> > I thought it would be in the next one after it's in the rc but perhaps not...
> >
> > I suspected that it could have been a slip up, since:
> > https://marc.info/?l=linux-netdev&m=154726015506044&w=2
> >
> > And i know that there are people waiting for it ;)
>
> Well, ask David and if he says I can queue it up now, I'll be glad to do
> so.
>
> thanks,
>
> greg k-h