Message-ID: <20190121162938.GA3544@ubu-Virtual-Machine>
Date:   Mon, 21 Jan 2019 11:29:38 -0500
From:   Kimberly Brown <kimbrownkd@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Dexuan Cui <decui@...rosoft.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        Long Li <longli@...rosoft.com>,
        Sasha Levin <Alexander.Levin@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] Drivers: hv: vmbus: Expose counters for interrupts
 and full conditions

On Thu, Jan 17, 2019 at 09:11:03AM -0800, Stephen Hemminger wrote:
> 
> 
> > +static ssize_t channel_intr_in_full_show(const struct vmbus_channel
> > *channel,
> > +					 char *buf)
> > +{
> > +	return sprintf(buf, "%llu\n", channel->intr_in_full);
> > +}
> 
> 
> intr_in_full is u64, which is not the same as unsigned long long.
> to be correct you need a cast here.
>

Thanks for the feedback. I'll fix this issue in all four of the "_show"
functions that are added in this patch.


> > > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> > > index dcb6977afce9..7e5239123276 100644
> > > --- a/include/linux/hyperv.h
> > > +++ b/include/linux/hyperv.h
> > > @@ -751,6 +751,27 @@ struct vmbus_channel {
> > >  	u64	interrupts;	/* Host to Guest interrupts */
> > >  	u64	sig_events;	/* Guest to Host events */
> > > 
> > > +	/* Interrupt counts for 2 types of Guest to Host interrupts */
> > > +	u64 intr_in_full;	/* in ring buffer, full to not full */
> > > +	u64 intr_out_empty;	/* out ring buffer, empty to not empty */
> > > +
> > > +	/*
> > > +	 * The total number of write operations that encountered a full
> > > +	 * outbound ring buffer.
> > > +	 */
> > > +	u64 out_full_total;
> > > +	/*
> > > +	 * The number of write operations that were the first to encounter a
> > > +	 * full outbound ring buffer.
> > > +	 */
> > > +	u64 out_full_first;
> 
> Adding more fields changes cache layout which can cause
> additional cache miss in the hot path.  
>

Good point. I think that the "intr_out_empty" field is in a good
location, but the "intr_in_full", "out_full_first", and "out_full_total"
fields could be moved to the end of the struct. These variables are used
only when ring buffer full conditions occur. Ring buffer full conditions
shouldn't be encountered often, and, if they are, they're a signal that
changes should probably be made to prevent them.

If you have any other suggestions for this, please let me know.


> > > +	/*
> > > +	 * Indicates that a full outbound ring buffer was encountered. The flag
> > > +	 * is set to true when a full outbound ring buffer is encountered and
> > > +	 * set to false when a write to the outbound ring buffer is completed.
> > > +	 */
> > > +	bool out_full_flag;
> 
> Discussion on kernel mailing list. Recommends against putting bool
> in structures since that pads to full sizeof(int).  Could this be
> part of a bitfield?
> 

There are currently 4 other bool variables in this struct. Maybe some or
all of the bool variables could be placed adjacent to each other and
changed into bitfields. I'll need to look into this.


> > >  	/* Channel callback's invoked in softirq context */
> > >  	struct tasklet_struct callback_event;
> > >  	void (*onchannel_callback)(void *context);
> > > @@ -936,6 +957,23 @@ static inline void *get_per_channel_state(struct
> > > vmbus_channel *c)
> > >  static inline void set_channel_pending_send_size(struct vmbus_channel *c,
> > >  						 u32 size)
> > >  {
> > > +	unsigned long flags;
> > > +
> > > +	spin_lock_irqsave(&c->outbound.ring_lock, flags);
> > > +
> > > +	if (size) {
> > > +		++c->out_full_total;
> > > +
> > > +		if (!c->out_full_flag) {
> > > +			++c->out_full_first;
> > > +			c->out_full_flag = true;
> > > +		}
> > > +	} else {
> > > +		c->out_full_flag = false;
> > > +	}
> > > +
> > > +	spin_unlock_irqrestore(&c->outbound.ring_lock, flags);
> 
> If this is called often, the additional locking will impact performance.
>

In hv_sock, each call of "hvs_stream_has_space()" results in a call to
"channel_set_pending_send_size()", so this could be a concern. I'll work
on addressing this issue.


> > >  	c->outbound.ring_buffer->pending_send_sz = size;
> > >  }
> > > 
> 
> Could I propose another alternative.
> 
> It might be more useful to count the guest to host interaction events
> rather than the ring buffer.
> 
> For example the number of calls to:
> 	vmbus_set_event which means host exit call
> 	vmbus_setevent fastpath using sync_set_bit
> 	calls to rinbuffer_write that returned -EAGAIN
> 
> These would require less locking, reuse existing code paths
> and not require additional state.
> 

I'm not sure that this approach would provide the data that we're
looking for. For example, we're interested in evaluating how often ring
buffer write operations encounter full conditions. For this, we need to
know how many interaction events were caused by the ring buffer being
full. Counting the number of calls to "vmbus_set_event()" and
"vmbus_setevent()" wouldn't allow us to determine what caused the events.

For counting the full conditions, the number of calls to
"ring_buffer_write()" that returned -EAGAIN isn't sufficient because
hv_sock doesn't use the -EAGAIN path to determine that the ring buffer is
full. Therefore, we need to count the number of full conditions in both
"ring_buffer_write()" and "set_channel_pending_send_size()".

Powered by blists - more mailing lists