linux-kernel - Re: [PATCH v1] fs/jfs: Switch to use new generic UUID API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2df5858-3428-b4ba-e779-4dc5ecbac16b@oracle.com>
Date:   Mon, 21 Jan 2019 11:46:03 -0600
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, jfs-discussion@...ts.sourceforge.net
Subject: Re: [PATCH v1] fs/jfs: Switch to use new generic UUID API

On 1/21/19 10:23 AM, Christoph Hellwig wrote:
> On Mon, Jan 21, 2019 at 10:19:15AM -0600, Dave Kleikamp wrote:
>> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
>> index 65d8fc87ab11..c15ff56a8516 100644
>> --- a/fs/jfs/super.c
>> +++ b/fs/jfs/super.c
>> @@ -174,9 +174,11 @@ static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf)
>>  	buf->f_files = maxinodes;
>>  	buf->f_ffree = maxinodes - (atomic_read(&imap->im_numinos) -
>>  				    atomic_read(&imap->im_numfree));
>> -	buf->f_fsid.val[0] = (u32)crc32_le(0, sbi->uuid, sizeof(sbi->uuid)/2);
>> -	buf->f_fsid.val[1] = (u32)crc32_le(0, sbi->uuid + sizeof(sbi->uuid)/2,
>> -					sizeof(sbi->uuid)/2);
>> +	buf->f_fsid.val[0] = crc32_le(0, (char *)&sbi->uuid,
>> +				      sizeof(sbi->uuid)/2);
>> +	buf->f_fsid.val[1] = crc32_le(0,
>> +				      (char *)&sbi->uuid + sizeof(sbi->uuid)/2,
>> +				      sizeof(sbi->uuid)/2);
> 
> I'd really love to see a little helper to calculate the fsid, and
> a comment on that function documenting the design decision behind it.

I can do that. It was a long time ago, but I'm sure the design decision
was that I took the idea from another filesystem, possibly reiserfs, but
I'll make a better case than that. :-)

Shaggy